Programmer Humor

20906 readers

1691 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

Keep content in english
No advertisements
Posts must be related to programming or programmer topics

founded 2 years ago

MODERATORS

[email protected]

367

Seriously how many times does this have to happen (lemmy.world)

submitted 7 months ago by [email protected] to c/[email protected]

46 comments fedilink hide all child comments

One does not commit or compile credentials

Template

Context:

This meme was brought to you by the PyPI Director of Infrastructure who accidentally hardcoded credentials - which could have resulted in compromissing the entire core Python ecosystem.

you are viewing a single comment's thread
view the rest of the comments

[–] [email protected] 53 points 7 months ago* (last edited 7 months ago) (12 children)

At my workplace, we use the string @nocommit to designate code that shouldn't be checked in. Usually in a comment:

// @nocommit temporary for testing
apiKey = 'blah';
// apiKey = getKeyFromKeychain();

but it can be anywhere in the file.

There's a lint rule that looks for @nocommit in all modified files. It shows a lint error in dev and in our code review / build system, and commits that contain @nocommit anywhere are completely blocked from being merged.

(the code in the lint rule does something like "@no"+"commit" to avoid triggering itself)

[–] [email protected] 9 points 7 months ago (4 children)

This sounds like a really useful solution, how do you implement something like this? Especially with linter integration

[–] zqwzzle 4 points 7 months ago (1 children)

Depending on which stack you’re using, you could use https://danger.systems to automatically fail PRs.

[–] [email protected] 4 points 7 months ago (1 children)

PRs? Isn't the point of @nocommit that something does not get committed, and therefore no credentials are stored in the git repository? Even if the PR does not get merged, the file is still stored as a hit object and can be restored.

[–] zqwzzle 2 points 7 months ago

I read the lint part and my brain forgot about everything else. You could stick the danger call in a pre commit hook though.

load more comments (2 replies)

load more comments (9 replies)