Just wrapped up a call with @[email protected] and @[email protected] to review their implementations of FEP 7888, specifically in relation to conversational backfill.
:heavy_check_mark: individual objects serve a context property
:heavy_check_mark: that context property is a URL that resolves
One of the concerns raised was related to the OrderedCollection of items served by the context. Specifically, if the items presented in the collection were not in chronological order, NodeBB failed at importing some of the items as the inReplyTo referenced an object that did not exist.
The solution to this was to ensure that the collection items were in chronological order from oldest to newest. Once fixed:
:heavy_check_mark: the context resolved to an OrderedCollection containing objects
:heavy_check_mark: NodeBB was able to pull in the entire conversation
NodeBB used to guard against this by ordering all received items by chronological order, but I realized that while this worked 99%+ of the time, there are some fun (ahem...) individuals who send objects with timestamps way in the future.
Personally I think removing the sorting just to fix one edge case was premature. At the same time, I think specifying that the OrderedCollection be sorted in chronological order should be a requirement.
cc @[email protected]
@julian @pfefferle @jesseplusplus @harmonicarichard @trwnh
>yes, but they serve objects because we're radical implementors who don't do the whole activities thing ๐ sorry in advance.
My server can retrieve both kinds of collections :) I had concerns about diverging / conflicting implementations in the past, but the solution was found...
>We were testing against these URLs from @[email protected]'s personal blog
This context is working ๐
>@[email protected] had a test URL but NodeBB fell over because it encountered an Object in next instead of a URL
I have a problem with this one because the
firstpage doesn't have anid. I can adjust my code but the absence ofidis unusual. For example, there is anextpage (currently 404), and if we navigate to it, howprevwould look like if the first page is anonymous?>All top level or mid-level objects should report a resolvable context
Do you mean replies made by the context owner specifically? I think remote mid-level replies should not be required to have
context(that would prevent non-implementing servers from participating).@[email protected] said in FEP 7888 serving up an OrderedCollection: > Do you mean replies made by the context owner specifically?
Correct, or more specifically, at least for all replies coming from the instance that the context owner belongs to... so other sibling replies by users on that instance should also report that same context.
@[email protected] you can also test against this instance, though I assume you already tried:
contexturl: https://community.nodebb.org/topic/18632@julian Yes, I tested against NodeBB and other implementations mentioned in FEP-f228. Will add WordPress and Frequency to the list