Technology

63375 readers

4538 users here now

This is a most excellent place for technology news and articles.

Our Rules

Follow the lemmy.world rules.
Only tech related content.
Be excellent to each other!
Mod approved content bots can post up to 10 articles per day.
Threads asking for personal tech support may be deleted.
Politics threads may be removed.
No memes allowed as posts, OK to post as comments.
Only approved bots from the list below, to ask if your bot can be added please contact us.
Check for duplicates before posting, duplicates may be removed
Accounts 7 days and younger will have their posts automatically removed.

Approved Bots

founded 2 years ago

MODERATORS

[email protected]

453

GitHub - LadybirdBrowser/ladybird: Truly independent web browser (github.com)

submitted 21 hours ago by [email protected] to c/[email protected]

157 comments fedilink hide all child comments

you are viewing a single comment's thread
view the rest of the comments

[–] [email protected] 2 points 14 hours ago* (last edited 14 hours ago) (1 children)

It’s not unreasonable to think that, when they wrote it, it really hadn’t been merged and they only saw the initial denial citing the policy.

That never happened on this PR. The only human reply before the merge (aside from the submitter) was this:

Please fix the commit messages (see BuggieBot's comment); and maybe this can go in one commit? Doesn't really need to be 5 separate ones.

And this is BuggieBot's comment:

Hello!

One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

It's a completely different.

This, plus the tone of the blog post looks like they were on a crusade instead of trying to accurately portray events.

Sorry to beat a dead horse here, my point is that we all need to be careful jumping to conclusions, especially in FOSS where discussion almost exclusively happens asynchronously in text and with people with different backgrounds. Pretty much everyone involved failed at that.

I agree with the rest.

[–] [email protected] 1 points 14 hours ago (1 children)

And this is BuggieBot’s comment:

Yeah I was referencing that comment.

Sequence of events:

PR trying to change pronouns.
Automated response citing policy.
Author takes note of it for blog post.
PR fixed and merged.
Blog post published.

Precocious, certainly, and I agree it was misguided. The blog post was indeed emotionally motivated, that's more than clear.

Sorry to beat a dead horse here

It's alright. I think these discussions need to be had.

[–] [email protected] 3 points 13 hours ago (1 children)

Right, but the policy was commit hygiene (lots of small commits), which has nothing to do with the "no politics" policy. It's right there in the comment, and the suggestion is to squash the commits into one.

It’s alright. I think these discussions need to be had.

Agreed. And unfortunately, I felt it necessary to be really wordy to not come off as supporting intolerance in any way, while still arguing that I would've done the same (reject 1-line cosmetic PRs).

This is some kind of correlary to Poe's Law, or perhaps Godwin's Law.

[–] [email protected] 2 points 13 hours ago (1 children)

Right, but the policy was commit hygiene (lots of small commits), which has nothing to do with the “no politics” policy. It’s right there in the comment, and the suggestion is to squash the commits into one.

Suspiciously close to what Hitler would say... /s

[–] [email protected] 2 points 13 hours ago* (last edited 13 hours ago)

Lol, got me there.

Hitler would probably be a formatting Nazi too. Can't have that extra whitespace.