this post was submitted on 12 Apr 2025
195 points (90.1% liked)

Technology

69041 readers
5540 users here now

This is a most excellent place for technology news and articles.


Our Rules


  1. Follow the lemmy.world rules.
  2. Only tech related news or articles.
  3. Be excellent to each other!
  4. Mod approved content bots can post up to 10 articles per day.
  5. Threads asking for personal tech support may be deleted.
  6. Politics threads may be removed.
  7. No memes allowed as posts, OK to post as comments.
  8. Only approved bots from the list below, this includes using AI responses and summaries. To ask if your bot can be added please contact a mod.
  9. Check for duplicates before posting, duplicates may be removed
  10. Accounts 7 days and younger will have their posts automatically removed.

Approved Bots


founded 2 years ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
[โ€“] [email protected] 1 points 1 week ago (1 children)

Sir, I will make sure to never bother you with a PR and my terrible, terrible code ;)

[โ€“] [email protected] 1 points 1 week ago* (last edited 1 week ago)

Rejecting a PR shouldn't be offensive, it should be a learning opportunity, both for the reviewer and the submitter. If I reject it, I'll give a clear reason why, and suggestions on how to fix it. I'll also engage in conversation if you're not clear on why I made a given comment, as well as a defense for why your code should be accepted as-is (i.e. that context I'm talking about).

So please bother me with terrible, terrible code. I want to take time out of my day to help contributors learn, and I like pointing out areas where I learn something as well (like, "hey, this is really clever and also really easy to read, good job!"). I'm not always right, but I do have a lot of experience that I think others could benefit from. I know I was deeply appreciative of constructive criticism as a new dev, and I hope that's true for the people I provide reviews for.